Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color change in timeline #113

Open
mscuthbert opened this issue Apr 2, 2018 · 3 comments
Open

Color change in timeline #113

mscuthbert opened this issue Apr 2, 2018 · 3 comments

Comments

@mscuthbert
Copy link
Collaborator

@mscuthbert mscuthbert commented Apr 2, 2018

this is a tiny little thing, but I associate Green w/ good and Blue with neutral. Any objections to my changing the timeline to make Py2/3 Blue and Py3-only Green? And we can use Yellow/Red for the Python 2.7 code to make it stand out (as the only Py2-only bar currently on the graph).

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 2, 2018

feel free to send a PR it will be autodeployed on a separate domain to see how it looks like.

I think we keept the py2/3-python-2.7 same color, and avoided red as we don't want to stigmatize python2.7 as "bad".

I guess that would look something like that:

screen shot 2018-04-02 at 09 11 30

@mscuthbert
Copy link
Collaborator Author

@mscuthbert mscuthbert commented Apr 2, 2018

I'll do a pull in a bit -- I agree that red for anything except Python 2.7 itself sends too strong a signal. I was thinking a bit more like:

screen shot 2018-04-02 at 12 24 43

(colors aren't exact; I just eyeballed them in shifting the stylesheet)

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.