Skip to content

/ PyMatcha

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Dockerfile for frontend to use production build #263

Open
Seluj78 opened this issue Sep 19, 2020 · 2 comments
Open

Change Dockerfile for frontend to use production build #263

Seluj78 opened this issue Sep 19, 2020 · 2 comments
Assignees
@supalarry
Labels
Frontend
Projects
Frontend

Comments

@Seluj78
Copy link
Owner

@Seluj78 Seluj78 commented Sep 19, 2020 

frontend      |   It seems you are running Vue CLI inside a container.
frontend      |   Access the dev server via http://localhost:<your container's external mapped port>/
frontend      | 
frontend      |   Note that the development build is not optimized.
frontend      |   To create a production build, run yarn build.

For now it works as we're still developping but on release we need to change the dockerfile to build the front for prod and then serve it
@Seluj78 Seluj78 added the Frontend label Sep 19, 2020
@Seluj78 Seluj78 added this to To do in Frontend via automation Sep 19, 2020
@supalarry
Copy link
Collaborator

@supalarry supalarry commented Nov 17, 2020

Maybe launch vue in quet mode.
@Seluj78
Copy link
Owner Author

@Seluj78 Seluj78 commented Nov 17, 2020

I still do think we need to change the dockerfile at the end to use the production build so we avoid some errors and remove the vue devs tools info in the console as well as a faster overall experience because it will be optimized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supalarry supalarry

Labels
Frontend
Projects
Frontend
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Seluj78 @supalarry
You can’t perform that action at this time.