Skip to content

chore: Only run freeze reminder on internal repo #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 23, 2020

Why:

Shouldn't affect forks or the public repo, but I'm guessing this will start triggering double notifications running on the public and private repo on the same cron schedule. The env.FREEZE check could probably be hoisted here too

What's being changed:

Check off the following:

@nschonni nschonni requested a review from a team as a code owner October 23, 2020 21:37
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@janiceilene janiceilene added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! engineering Will involve Docs Engineering labels Oct 27, 2020
@rachmari rachmari merged commit 04a94d0 into github:main Oct 28, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the patch-1 branch October 28, 2020 00:43
@JamesMGreene
Copy link
Member

I appreciate the critical eye and the contribution! 🙇🏻‍♂️ 💝

FWIW, I intentionally left this out when I created it to ensure we remembered to unfreeze both repos when the time came. We can try it this way and hopefully it works out as well. 😅

@nschonni
Copy link
Contributor Author

@JamesMGreene fair enough, I figured it would more be noise in the slack channel, but feel free to revert as I can see it might catch only clearing the variable in one repo :)

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants