Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #23019

Merged
merged 1 commit into from Feb 3, 2021
Merged

Fix typo #23019

merged 1 commit into from Feb 3, 2021

Conversation

@Harry-Lees
Copy link
Contributor

@Harry-Lees Harry-Lees commented Oct 29, 2020

Fixed possible typo in comment

Automerge-Triggered-By: GH:Mariatta

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Oct 29, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Harry-Lees

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

@github-actions github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Dec 16, 2020
@pganssle pganssle removed the stale label Dec 16, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Jan 16, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jan 16, 2021
Copy link
Member

@Mariatta Mariatta left a comment

Thanks

@pganssle
Copy link
Member

@pganssle pganssle commented Jan 16, 2021

I think this is not a typo, or if it is this is not the right solution. There is no method or calls called datetime.timetz.

@pganssle
Copy link
Member

@pganssle pganssle commented Jan 16, 2021

Oh wait, ignore that. Wrong on both counts, apparently.

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jan 16, 2021

So, is this ready to merge, or do you want to do it @pganssle ? I added backport labels.

@github-actions github-actions bot removed the stale label Jan 17, 2021
@miss-islington miss-islington merged commit bfe544d into python:master Feb 3, 2021
9 checks passed
9 checks passed
Check for source changes
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201029.1 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 3, 2021

Thanks @Harry-Lees for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 3, 2021

Sorry @Harry-Lees, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bfe544d2f2c2e7a7c03a764bed3276a1e27a0f5c 3.9

@miss-islington miss-islington self-assigned this Feb 3, 2021
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 3, 2021

GH-24434 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 3, 2021

Thanks @Harry-Lees for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 3, 2021
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 3, 2021

GH-24435 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 3, 2021
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <[email protected]>
miss-islington added a commit that referenced this pull request Feb 3, 2021
Fixed possible typo in comment
(cherry picked from commit bfe544d)

Co-authored-by: Harry <[email protected]>
ncoghlan added a commit to ncoghlan/cpython that referenced this pull request Feb 8, 2021
Fixed possible typo in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants