JS: refactor parameterPropRead and reachesReturn to get a slight performance improvement
#4549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance improvement
erik-krogh
force-pushed
the
pruneReturn
branch
from
2899820 to
33465db
Compare
asgerf
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real change is this new call
callInputStep(f, _, _, _, _)insidereachesReturn, which pulls some context intoreachesReturnto make the result of the predicate smaller.The rest is just moving things around.
Only adding the
callInputStep(..)call, or only moving things around, does not improve performance. Both are needed.This was motivated by me noticing that
reachesReturnwas computing a needlessly big result, where most the of rows were pruned afterwards.An thorough evaluation shows an average speedup of 0.5-1%.
But the result depends on the benchmark.
A benchmark like
azure-sdk-for-nodesees a 3-4% speedup, while other benchmarks see a small slowdown.