Skip to content

Update guidelines-for-legal-requests-of-user-data.md#792

Merged
felicitymay merged 2 commits intogithub:mainfrom
kshobaki:patch-3
Nov 6, 2020
Merged

Update guidelines-for-legal-requests-of-user-data.md#792
felicitymay merged 2 commits intogithub:mainfrom
kshobaki:patch-3

Conversation

@kshobaki
Copy link
Copy Markdown
Contributor

@kshobaki kshobaki commented Oct 25, 2020 โ€ข

Screen Shot 2020-10-25 at 7 32 51 AM

Fixed floating bullet for "under exigent circumstances"

Why:

What's being changed:

Check off the following:

Fixed floating bullet for "under exigent circumstances"
@welcome
Copy link
Copy Markdown

welcome Bot commented Oct 25, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@@ -194,7 +194,6 @@ In addition to the non-public user account information and account access logs m
- Any security keys used for authentication or encryption

- <a name="in-exigent-circumstances"></a>

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be missing something here (I'm relatively new to markdown, trying to translate from my HTML brain), but this should actually be an unordered list item, and I think removing the space fixed it. That said, if there's a more syntax correct way to do it, I defer!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, your fix is right ๐Ÿ˜„
I get tripped up in this repo because their custom rendering doesn't seem to follow either CommonMark or GitHub Flavored Markdown rules ๐Ÿคท

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks for opening a PR @kshobaki! I'll get this triaged for review โšก

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! labels Oct 28, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Nov 4, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 5, 2020
@janiceilene
Copy link
Copy Markdown
Contributor

@kshobaki This is definitely not stale, thanks so much for your patience!

Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow response here. Somehow your PR had ended up on the project board in a location that showed we were waiting for a response from you ๐Ÿคฆ๐Ÿป

We clearly need to tweak our processes!

The fix looks great on staging. We don't often mix HTML into our markdown files and I guess this is why the error crept in.

@felicitymay felicitymay merged commit 406e27f into github:main Nov 6, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2020

Thanks very much for contributing! Your pull request has been merged ๐ŸŽ‰ You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants