Skip to content

[3.8] bpo-32498: Improve exception message on passing bytes to urllib.parse.unquote #22746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taleinat merged 3 commits into from
Oct 18, 2020
Merged

[3.8] bpo-32498: Improve exception message on passing bytes to urllib.parse.unquote #22746

taleinat merged 3 commits into from
Oct 18, 2020

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 18, 2020 •
edited by taleinat
Loading

bytes input is supported in 3.9, but not in 3.8. This improves the exception message for 3.8.

https://bugs.python.org/issue32498

taleinat
taleinat requested changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs a little NEWS entry.

@bedevere-bot
Copy link

bedevere-bot commented Oct 18, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@iritkatriel
Copy link
Member Author

iritkatriel commented Oct 18, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Oct 18, 2020

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from taleinat October 18, 2020 19:24
@taleinat taleinat changed the title bpo-32498: Improve exception message on passing bytes to urllib.parse… [3.8] bpo-32498: Improve exception message on passing bytes to urllib.parse.unquote Oct 18, 2020
@taleinat taleinat merged commit 1a3f7c0 into python:3.8 Oct 18, 2020
@taleinat
Copy link
Contributor

taleinat commented Oct 18, 2020

Thanks for this PR, @iritkatriel!

@iritkatriel iritkatriel deleted the bpo32498 branch October 18, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel @bedevere-bot @taleinat @the-knights-who-say-ni