Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce version 5 support or clarify that it was replaced by the version 7 prerelease #89

Open
connor-roehricht opened this issue Sep 20, 2020 · 0 comments

Comments

@connor-roehricht
Copy link

@connor-roehricht connor-roehricht commented Sep 20, 2020

Observation

  1. https://github.com/PowerShell/PowerShellStandard/tree/master/src/5 contains only references to 7 (note that the folder is still named 5).
  2. https://github.com/PowerShell/PowerShellStandard/blob/master/src/dotnetTemplate/README.md contains a sample help text that only mentions 3 and 7.
  3. This is inconsistent with the content of https://github.com/PowerShell/PowerShellStandard/blob/master/src/dotnetTemplate/Microsoft.PowerShell.Standard.Module.Template/Microsoft.PowerShell.Standard.Module.Template/.template.config/template.json , which is why the template currently does not work (besides #81)

Proposed Solutions

Option A

Reintroduce version 5 support by correcting the changes made in c7c7ad3 . #87 and #88 are then obsolete.
This seems to be preferred: #88 (comment)

Option B

Clarify that only 3 and 7 are supported now by removing references to 5 (could be done by renaming the aforementioned folder + merging of #88)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.