C++: Be more consistent about unnamed entities#4471
Merged
Conversation
igfoo
added
C++
depends on internal PR
Contributor
|
The change to unnamed parameters is scary but probably also healthy. I agree it's the right thing to have done in the long run. I'm not convinced that all constructors should be named |
Member
Author
|
It's not all constructors, it's only unnamed constructors, e.g. the constructor for the unnamed class behind a lambda. |
jbj
previously approved these changes
Oct 16, 2020
dbartol
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the
(unnamed ...)format for more functions, and for parameters.