Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: searchbox is wrapping under the separation line for screen sizes #33

Open
wants to merge 1 commit into
base: master
from

Conversation

@tapaswenipathak
Copy link
Contributor

@tapaswenipathak tapaswenipathak commented Oct 15, 2019

Fixes #7.

Hello maintainers: folks who feel ok for reviewing the css changes?

cc @theacodes @ncoghlan @brettcannon @Mariatta (top contributors).

@tapaswenipathak tapaswenipathak force-pushed the tapaswenipathak:issue-7 branch from 214e06a to 156a8b1 Oct 15, 2019
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 18, 2019

@tapaswenipathak please be careful about @ mentioning folks blindly to try and get a review. For instance, I have only contributed twice, so I'm not in a good position to review anything in this repo and I have 25 other notifications in GitHub right now and so this is unfortunately a distraction for me when I can't help.

But I will say thanks for trying and hopefully someone in a better position will be able to review your changes.

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Oct 20, 2019

Thanks for trying to enhance the CSS, I appreciate it, while not being able to understand it. Hope someone can review this :)

@tapaswenipathak
Copy link
Contributor Author

@tapaswenipathak tapaswenipathak commented Oct 24, 2019

@brettcannon: People tagged are the top contributors in the repository and maintainers in the org, I think, how else you can decide who can review the PR. No problem if you technically still don't understand the changes. Thanks for taking the time for writing what you think.

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 24, 2019

@tapaswenipathak I would say it's not your problem to have to know who should review the PR. It's up to the project to decide how they want to handle assigning PR reviews and make sure there is a process in place to handle that.

@zware zware requested a review from theacodes Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.