Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix hyphenation in Chrome #54
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There's a bug or two in Chromium (e.g. Chrome, Opera) such that the Lucida Grande font doesn't hyphenate properly (with
hyphens: auto) which makes things harder to read.This shows up on macOS, which has this this font, but not on Android or Windows, which use the fallback Arial. Firefox and Safari are okay.
This affects at least docs.python.org and pip.pypa.io, and both use this theme.
Before
Here's an example from https://pip.pypa.io/en/stable/development/release-process/ in newest Chrome 85 on macOS Mojave:
(Created with
sphinx-quickstartusing the defaults, changinghtml_theme = 'alabaster'to'python_docs_theme', putting some pip text inindex.rstand runningrm -rf _build; make html: sphinx-test2.zip.)After
This PR suggests to ditch Lucida Grande, at least until when and if the Chrome bug is fixed and widely deployed. This would also make it consistently use Arial as on non-Macs:
See also my original PR at pypa/pip#8879 to disable
hyphens: auto, but they'd prefer to fix the upstream theme.