Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake copybutton messages translatable #27
+13
−2
Conversation
See issue #23.
|
There's a little issue, the command gathering translations strings: won't pick it up, so translation teams won't see it as a sentence to translate. I don't have the time right now to check if there's a simple way to solve this, maybe Sphinx has a way to look for translations strings in configured theme? |
|
These resources might be helpful: |
|
I think I looked into this in the past and it was possible to directly translate the strings in the javascript file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR implements #23 which make the messages of copybutton (
>>>) translatable.When I tested my change using the master branch of Python (branch 3.7 doesn't seem to use python-docs-theme), I couldn't get it read my modified
layout.html. However, if I manually introduced the change, the pot files would include the new strings and the translation worked.I think it is better to have someone more familiar with the project structure of PEP 545 to test my implementation before it is merged.