bpo-41756: Delete PyGen_Send function #22663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Oct 12, 2020
| @@ -269,13 +269,29 @@ gen_send_ex2(PyGenObject *gen, PyObject *arg, PyObject **presult, | |||
| } | |||
|
|
|||
| PySendResult | |||
| PyGen_Send(PyGenObject *gen, PyObject *arg, PyObject **result) | |||
| PyIter_Send(PyObject *iter, PyObject *arg, PyObject **result) | |||
There was a problem hiding this comment.
Hm, what function does the ceval look call now when in tracing?
There was a problem hiding this comment.
It calls _PyObject_CallMethodIdOneArg(receiver, &PyId_send, v).
1st1
approved these changes
Oct 12, 2020
|
@1st1: Please replace |
|
Thanks @vladima and @serhiy-storchaka! |
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This was referenced Feb 14, 2021
Merged
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Delete
PyGen_Sendfunction and inline its body intoPyIter_Send. This PR does not introduce new functionality so there is nothing to report in news.https://bugs.python.org/issue41756