Skip to content

Fix documentation typos of argparse exit_on_error #22706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix documentation typos of argparse exit_on_error #22706

merged 1 commit into from
Apr 26, 2021

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Oct 15, 2020

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@hukkinj1

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 15, 2020
@tirkarthi tirkarthi requested a review from rhettinger October 15, 2020 17:08
tirkarthi
tirkarthi approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi
Copy link
Member

There is an additional issue around this parameter's clarity in documentation. Please see also https://bugs.python.org/issue41255

@hukkin
Copy link
Contributor Author

hukkin commented Oct 15, 2020

CLA now successfully signed.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@hukkin
Copy link
Contributor Author

hukkin commented Dec 16, 2020

This comment is here just so that the evil github-actions bot doesn't close this PR 😄

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
serverwentdown
serverwentdown approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@serverwentdown serverwentdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor correction of grammar.

@orsenthil orsenthil merged commit 7be870f into python:master Apr 26, 2021
@miss-islington
Copy link
Contributor

Thanks @hukkinj1 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hukkinj1 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-25617 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@hukkinj1 @miss-islington
Fix documentation typos of argparse exit_on_error (pythonGH-22706)
c717d5e 
(cherry picked from commit 7be870f)

Co-authored-by: Taneli Hukkinen <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 26, 2021
@miss-islington
Copy link
Contributor

Sorry, @hukkinj1 and @orsenthil, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7be870f9456ad04c3b67881497de6346d83805d2 3.8

orsenthil pushed a commit that referenced this pull request Apr 26, 2021
@miss-islington @hukkinj1
Fix documentation typos of argparse exit_on_error (GH-22706) (GH-25617)
4cb9816 
(cherry picked from commit 7be870f)

Co-authored-by: Taneli Hukkinen <[email protected]>
@hukkin hukkin deleted the patch-1 branch March 2, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serverwentdown serverwentdown serverwentdown approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@orsenthil orsenthil

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hukkin @the-knights-who-say-ni @tirkarthi @miss-islington @bedevere-bot @serverwentdown @orsenthil @hukkinj1