-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-41544: Add missing parameters to dummy.DummyProcess and dummy.Pool #21869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduce daemon parameter to multiprocessing.dummy.DummyProcess in order to match the API of multiprocessing.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This needs a unit test. |
|
It seems to me that there are not tests at all for I'd appreciate any help with this. |
|
I added test_multiprocessing_dummy and it runs successfully. It shouldn't, however, because EDIT: It seems that if In my eyes, to make use of the current test machinery, we need to make "dummy" a supported (but maybe undocumented) start method. EDIT: I see why this doesn't work: The |
|
I moved on to checking only the signatures. Also, I added the missing |
|
@ZackerySpytz What do you think? |
Add missing parameters to multiprocessing.dummy.DummyProcess in order to match the API of multiprocessing.Process.
https://bugs.python.org/issue41544