Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Improve gitbootcamp.rst #524
Conversation
|
Thanks for the PR @maggyero! I would recommend adjusting the title from "Update" to "Improve". Updating would imply that some parts are no longer relevant, and are being updated accordingly. The changes made in this PR would be better described as improvements or fixes. Overall, I agree with many of the changes made, but I have some suggestions: |
Co-Authored-By: Kyle Stanley <[email protected]>
Co-Authored-By: Kyle Stanley <[email protected]>
|
@aeros167 Thanks for the review. I have applied some of your suggestions. |
Co-Authored-By: Emmanuel Arias <[email protected]>
I don't think this is a good idea. Examples helps readers than variables sometime. For example, |
In that case, I think we should aim to consistently use one format or the other within the article, as switching between the two could cause some degree of confusion. I'm okay with using quotes instead of tags though. Another alternative would be to use italics, that format is used commonly in a number of different areas of documentation to tell the reader that they should insert their own value: git config --global user.name "Your Name" In that example, the quotation marks have a functional purpose (telling git to treat it as a single argument even with the spaces). |
I don't think it causes real confusion. Variables are useful when the same word is used several times. But it is not so useful when it is used only once like As I described above, |
Okay, I see. As an example, do you think it's useful in the following context for
I agree, I just thought that the italics might be useful, such as "Your Name". It helps to make the text stand out to the reader, and indicate they should substitute their own text there. In the specific case of "Your Name" it's fairly clear either way, it just makes it more obvious. |
Yes.
So It may be more helpful to add more comment like this:
|
|
@methane Alright, updated, thanks for the review. |
This PR will apply the following changes to gitbootcamp.rst:
<x>consistently.