Skip to content

Conversation

@matt-gretton-dann
Copy link
Contributor

Updates tests whose results change by adding constinit support.

This will fail testing as it depends on an internal C++ Extractor change.

@matt-gretton-dann matt-gretton-dann added C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR labels Oct 5, 2020
@matt-gretton-dann matt-gretton-dann requested a review from a team as a code owner October 5, 2020 10:33
@matt-gretton-dann matt-gretton-dann force-pushed the matt-gretton-dann/cpp20-constinit-results branch from 0f66c4f to 269a2c3 Compare October 13, 2020 10:39
@intrigus-lgtm
Copy link
Contributor

Very minor: You have a typo in your commit message.

@matt-gretton-dann matt-gretton-dann force-pushed the matt-gretton-dann/cpp20-constinit-results branch from 269a2c3 to b57383f Compare October 13, 2020 10:45
@matt-gretton-dann matt-gretton-dann force-pushed the matt-gretton-dann/cpp20-constinit-results branch 3 times, most recently from 813a4f8 to e605032 Compare November 10, 2020 14:12
geoffw0
geoffw0 previously approved these changes Nov 16, 2020
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@geoffw0 geoffw0 merged commit decbb08 into main Nov 18, 2020
@tausbn tausbn deleted the matt-gretton-dann/cpp20-constinit-results branch May 9, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants