Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBE - Notifications #54
Merged
Conversation
lms/lmsdb/models.py
Outdated
| marked_read = BooleanField(default=False) | ||
|
|
||
| @property | ||
| def message_parameters_dict(self) -> dict: |
This comment has been minimized.
This comment has been minimized.
yammesicka
Apr 14, 2020
Member
Avoid verbosity when it isn't needed
@property
def params(self) -> Dict[str, Any]:
| cls, | ||
| for_user: User, | ||
| ) -> Iterable['Notification']: | ||
| return cls.select().join(User).filter( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yammesicka
Apr 14, 2020
Member
For the sake of consistency, because where is much more documented and because this is a thing that represent a query (in which you use WHERE clause)
| cls, | ||
| user: User, | ||
| notification_type: str, | ||
| message_parameters: dict, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| def get_notifications_for_user(for_user: models.User) -> typing.Sequence[dict]: | ||
| return tuple( | ||
| { | ||
| models.Notification.ID_FIELD_NAME: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gal432
Apr 14, 2020
Author
Member
Why? I think its cleaner, I need more models here - what is the point?
This comment has been minimized.
This comment has been minimized.
yammesicka
Apr 14, 2020
Member
It's just hurt the eyes to see many linebreaks and I think it too verbose, but as you wish :)
| instance.create_notification(for_user=for_user, **kwargs) | ||
|
|
||
|
|
||
| def get_notifications_for_user(for_user: models.User) -> typing.Sequence[dict]: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gal432 commentedApr 13, 2020
No description provided.