Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make merge of 3.9 #1385

Merged
merged 5 commits into from Sep 11, 2020
Merged

Make merge of 3.9 #1385

merged 5 commits into from Sep 11, 2020

Conversation

@Seluj78
Copy link
Collaborator

Seluj78 commented Aug 24, 2020

No description provided.

@Seluj78 Seluj78 self-assigned this Aug 24, 2020
@Seluj78 Seluj78 added this to In progress in Traduction via automation Aug 24, 2020
about.po Outdated Show resolved Hide resolved
Seluj78 added 2 commits Aug 24, 2020
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Aug 24, 2020

Need review vite fait before merge plz

@@ -1960,6 +1960,16 @@ msgstr ""
"donc définir vous-même le bon attribut :attr:`restype` pour pouvoir les "
"utiliser."

#: library/ctypes.rst:None

This comment has been minimized.

@deronnax

deronnax Aug 24, 2020

Collaborator

c'est normal ce header avec le numéro de ligne à None ?

This comment has been minimized.

@Seluj78

Seluj78 Aug 25, 2020

Author Collaborator
@deronnax
Copy link
Collaborator

deronnax commented Aug 24, 2020

comment on peut review un diff de 10.000 lignes ? @JulienPalard c'est vraiment important de mettre à jour le header Creation-Date ? Osef non ? Au moins la moitié du diff c'est ça.

D'ailleurs, quasi tous les headers po sont inutiles maintenant avec git...

@christopheNan
Copy link
Collaborator

christopheNan commented Aug 25, 2020

comment on peut review un diff de 10.000 lignes ? @JulienPalard c'est vraiment important de mettre à jour le header Creation-Date ? Osef non ? Au moins la moitié du diff c'est ça.

D'ailleurs, quasi tous les headers po sont inutiles maintenant avec git...

Personnellement, je trouve ça utile. Après, tu peux personnaliser ton git-diff comme indiqué dans Contributing ou git diff -G '^"POT'.

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Aug 26, 2020

Du coup, merge ?

Copy link
Collaborator

christopheNan left a comment

🚀

Traduction automation moved this from In progress to Reviewer approved Sep 5, 2020
@Seluj78 Seluj78 merged commit 757ab3f into python:3.9 Sep 11, 2020
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
Traduction automation moved this from Reviewer approved to Done Sep 11, 2020
@Seluj78 Seluj78 deleted the Seluj78:39-make-merge branch Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Traduction
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.