additon of integers using LL #2370

csendranshi · 2020-08-29T15:20:29Z


        additon of integers using LL

TravisBuddy · 2020-08-29T15:25:13Z

Hey @csendranshi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d4a6c320-ea0b-11ea-9476-dd4d5d152bb6

cclauss · 2020-08-29T16:29:36Z

Cool! Our linter is a bit picky about code style. The easiest way to fix these issues is:

mv addNodes.py add_nodes.py
python3 -m pip install black
black add_nodes.py


        formatted

csendranshi · 2020-08-29T17:24:33Z

Thanks for the guidance! I have executed the instructions.

cclauss · 2020-08-29T21:14:33Z

data_structures/linked_list/add_nodes.py

+        self.head = None
+
+    # method to print the linked list
+    def printLL(self):


It is more Pythonic to define a .__str__() method that returns a str then then we can do print(my_linked_list).

cclauss · 2020-08-29T21:14:33Z

data_structures/linked_list/add_nodes.py

+
+# node definition
+class Node:
+    def __init__(self, data):


Please add Python type hints for function parameters as discussed in CONTRIBUTING.md.

cclauss · 2020-08-29T21:14:33Z

data_structures/linked_list/add_nodes.py

+            temp = temp.next
+
+    # method to push a new node onto the linked list
+    def push(self, newdata):


Please add Python doctests for .push() and .add() as discussed in CONTRIBUTING.md.


        changes made


        Merge pull request #1 from TheAlgorithms/master

update

TravisBuddy · 2020-09-02T15:02:05Z

Hey @csendranshi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 42c8ab60-ed2d-11ea-b6ba-27fe84eba218

TravisBuddy · 2020-09-02T15:04:16Z

Hey @csendranshi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 90e85d40-ed2d-11ea-b6ba-27fe84eba218

data_structures/linked_list/add_nodes.py

cclauss · 2020-09-02T15:25:04Z

data_structures/linked_list/add_nodes.py

+        """
+        >>> llist.push(9)
+        >>> llist.push(9)
+        >>> llist.push(9)


So this test shows that we can call LL.push() but it does not really prove that LL.push() did what we expected it to do. How can we have a test that proves that 9 is in the linked list twice?


        Update data_structures/linked_list/add_nodes.py

Co-authored-by: Christian Clauss <[email protected]>


        Update data_structures/linked_list/add_nodes.py

Co-authored-by: Christian Clauss <[email protected]>


        Update data_structures/linked_list/add_nodes.py

Co-authored-by: Christian Clauss <[email protected]>

TravisBuddy · 2020-09-02T16:17:33Z

Hey @csendranshi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cd712530-ed37-11ea-b6ba-27fe84eba218

data_structures/linked_list/add_nodes.py

cclauss · 2020-09-02T17:20:21Z

data_structures/linked_list/add_nodes.py

+
+
+# linkedlist definition
+class LL:


Suggested change

class LL:

class LinkedList:

cclauss · 2020-09-02T17:23:31Z

data_structures/linked_list/add_nodes.py

+    def __str__(self) -> str:
+        temp = self.head
+        while temp:
+            print(temp.data, end=" ")


Line 23 promises that this function will return a str instead of printing the str.

working on it, will change


        Update data_structures/linked_list/add_nodes.py

Co-authored-by: Christian Clauss <[email protected]>


        Update data_structures/linked_list/add_nodes.py

Co-authored-by: Christian Clauss <[email protected]>

TravisBuddy · 2020-09-02T18:19:06Z

Hey @csendranshi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c89a8720-ed48-11ea-b6ba-27fe84eba218


        Two blank lines before a class definition for placate flake8

cclauss · 2020-09-02T18:45:05Z

data_structures/linked_list/add_nodes.py

+            sums = (
+                temp1.data + temp2.data + carry[-1]
+            )  # adding the latest element appended to the carry list
+            if sums >= 0 and sums <= 9:


Suggested change

if sums >= 0 and sums <= 9:

if 0 <= sums <= 9:

TravisBuddy · 2020-09-02T18:49:43Z

Travis tests have failed

Hey @csendranshi,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0e85dce0-ed4d-11ea-b6ba-27fe84eba218

spamegg1 · 2020-09-09T06:42:50Z

@csendranshi Build log says

047 >>> llist = LL(9)
UNEXPECTED EXCEPTION: TypeError('init() takes 1 positional argument but 2 were given')

The constructor of LL as defined on lines 18-19:

def __init__(self):
    self.head = None

takes no parameters, but you supplied a parameter to it with LL(9).

Correct use would be like what you did on lines 80, 81, 82:

llist = LL()  # linkedlist 1

additon of integers using LL

Loading status checks…

6de7872

formatted

Loading status checks…

1a803ab

cclauss requested changes Aug 29, 2020

View changes

swapnanildutta approved these changes Sep 1, 2020

View changes

csendranshi added 2 commits Sep 2, 2020

changes made

Loading status checks…

6c5399d

Merge pull request #1 from TheAlgorithms/master

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

7f4a7d5

update

cclauss reviewed Sep 2, 2020

View changes

data_structures/linked_list/add_nodes.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 2, 2020

View changes

data_structures/linked_list/add_nodes.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 2, 2020

View changes

data_structures/linked_list/add_nodes.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 2, 2020

View changes

csendranshi and others added 3 commits Sep 2, 2020

cclauss reviewed Sep 2, 2020

View changes

data_structures/linked_list/add_nodes.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 2, 2020

View changes

data_structures/linked_list/add_nodes.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 2, 2020

View changes

data_structures/linked_list/add_nodes.py

# linkedlist definition

class LL:

This comment has been minimized.

Sign in to view

cclauss Sep 2, 2020
Member

Suggested change

class LL:

class LinkedList:

cclauss reviewed Sep 2, 2020

View changes

csendranshi and others added 2 commits Sep 2, 2020

Two blank lines before a class definition for placate flake8

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

909584a

cclauss reviewed Sep 2, 2020

View changes

TheAlgorithms / Python

additon of integers using LL #2370

additon of integers using LL #2370

csendranshi commented Aug 29, 2020 •

edited

TravisBuddy commented Aug 29, 2020

cclauss commented Aug 29, 2020

csendranshi commented Aug 29, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TravisBuddy commented Sep 2, 2020

TravisBuddy commented Sep 2, 2020

This comment has been minimized.

TravisBuddy commented Sep 2, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TravisBuddy commented Sep 2, 2020

This comment has been minimized.

TravisBuddy commented Sep 2, 2020

spamegg1 commented Sep 9, 2020 •

edited

TheAlgorithms / Python

Join GitHub today

additon of integers using LL #2370

additon of integers using LL #2370

Conversation

csendranshi commented Aug 29, 2020 • edited

Describe your change:

Checklist:

TravisBuddy commented Aug 29, 2020

TravisBuddy Request Identifier: d4a6c320-ea0b-11ea-9476-dd4d5d152bb6

cclauss commented Aug 29, 2020

csendranshi commented Aug 29, 2020

This comment has been minimized.

cclauss Aug 29, 2020 • edited

This comment has been minimized.

cclauss Aug 29, 2020

This comment has been minimized.

cclauss Aug 29, 2020

TravisBuddy commented Sep 2, 2020

TravisBuddy Request Identifier: 42c8ab60-ed2d-11ea-b6ba-27fe84eba218

TravisBuddy commented Sep 2, 2020

TravisBuddy Request Identifier: 90e85d40-ed2d-11ea-b6ba-27fe84eba218

This comment has been minimized.

cclauss Sep 2, 2020

TravisBuddy commented Sep 2, 2020

TravisBuddy Request Identifier: cd712530-ed37-11ea-b6ba-27fe84eba218

This comment has been minimized.

cclauss Sep 2, 2020

This comment has been minimized.

cclauss Sep 2, 2020

This comment has been minimized.

csendranshi Sep 2, 2020

TravisBuddy commented Sep 2, 2020

TravisBuddy Request Identifier: c89a8720-ed48-11ea-b6ba-27fe84eba218

This comment has been minimized.

cclauss Sep 2, 2020

TravisBuddy commented Sep 2, 2020

Travis tests have failed

TravisBuddy Request Identifier: 0e85dce0-ed4d-11ea-b6ba-27fe84eba218

spamegg1 commented Sep 9, 2020 • edited

csendranshi commented Aug 29, 2020 •

edited

cclauss Aug 29, 2020 •

edited

spamegg1 commented Sep 9, 2020 •

edited