Skip to content

bpo-41729: Fix test_winconsole failures (3) and hang.#22146

Merged
terryjreedy merged 1 commit intopython:masterfrom
terryjreedy:cz
Sep 12, 2020
Merged

bpo-41729: Fix test_winconsole failures (3) and hang.#22146
terryjreedy merged 1 commit intopython:masterfrom
terryjreedy:cz

Conversation

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Sep 8, 2020

The problems occurred with a debug repository build on machine
with freshly updated Windows 10 Pro.

https://bugs.python.org/issue41729

The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
@terryjreedy
Copy link
Member Author

I have two questions before merging, even if tests pass.

  1. Should be revised line be better removed?

  2. Does the arg clinic stuff need to be regenerated after this change? (If so, how?)

@terryjreedy
Copy link
Member Author

@zooba As author of the file and line in question, do you have any objection to changing it?

@terryjreedy
Copy link
Member Author

Approved by Steve Dower on the issue.

@terryjreedy terryjreedy merged commit 31c9828 into python:master Sep 12, 2020
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@terryjreedy terryjreedy deleted the cz branch September 12, 2020 05:52
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
(cherry picked from commit 31c9828)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-22211 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
(cherry picked from commit 31c9828)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-22212 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2020
The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
(cherry picked from commit 31c9828)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Sep 12, 2020
The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
(cherry picked from commit 31c9828)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
w-hsiung pushed a commit to w-hsiung/cpython that referenced this pull request Sep 5, 2023
The problems occured with a repository build on machine
with freshly updated Windows 10 Pro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments