Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to add co-author info. #318

Merged
merged 2 commits into from Jan 30, 2018
Merged

Mention how to add co-author info. #318

merged 2 commits into from Jan 30, 2018

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jan 29, 2018

When converting other people's patch, ensure to add the "Co-authored-by:" message.

When converting other people's patch, ensure to add the "Co-authored-by:" message.
attribution to the original patch author by adding "Original patch by
<author name>." to the pull request description and commit message.
attribution to the original patch author by adding "Co-authored-by:
Author Name <email_address> ." to the pull request description and commit message.

This comment has been minimized.

@matrixise

matrixise Jan 30, 2018
Member

why a Co-author ? If you are the author, and just this author, we don't have to use 'Co-authored-by'.

This comment has been minimized.

@Mariatta

Mariatta Jan 30, 2018
Author Member

This section is about creating a pull request based on another person's patch. In this case, I think co-author is appropriate.
If there's only one author, and the patch author and PR author is the same, then there is no need to add Co-authored-by.

This comment has been minimized.

@matrixise

matrixise Jan 30, 2018
Member

ok thanks

@matrixise matrixise merged commit af9567e into master Jan 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Mariatta Mariatta deleted the Mariatta-patch-1 branch Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.