Skip to content

Add heroku topic#1684

Merged
MikeMcQuaid merged 3 commits intogithub:masterfrom
parshnt:master
Aug 12, 2020
Merged

Add heroku topic#1684
MikeMcQuaid merged 3 commits intogithub:masterfrom
parshnt:master

Conversation

@parshnt
Copy link
Contributor

@parshnt parshnt commented Aug 6, 2020 โ€ข

Thank you for contributing! Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

All popular PaaS services are created as topics and GitHub contains lots of repositories containing this topic which would be available to more users if Heroku is made an official GitHub topic.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@parshnt parshnt changed the title Add Heroku Add heroku topic Aug 8, 2020
@parshnt
Copy link
Contributor Author

parshnt commented Aug 11, 2020

Hello @MikeMcQuaid,
can you review my PR?

@MikeMcQuaid MikeMcQuaid merged commit f35b378 into github:master Aug 12, 2020
@MikeMcQuaid
Copy link
Contributor

Thanks so much for your first contribution and sorry for the delay! Without people like you submitting PRs we couldn't run this project. You rock, @parshnt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants