Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for external predicates. #408

Open
jcreedcmu opened this issue May 28, 2020 · 2 comments
Open

Support for external predicates. #408

jcreedcmu opened this issue May 28, 2020 · 2 comments
Labels
enhancement New feature or request QL4E parity This issue corresponds to a feature from QL4E not yet implemented for VSCode VSCode

Comments

@jcreedcmu
Copy link
Contributor

Add ability to run queries with predicates marked external, and ability to use prior query runs as input data for external predicates. This would allow very flexible custom notions of comparison and filtering of previous query results.

@jcreedcmu jcreedcmu added enhancement New feature or request QL4E parity This issue corresponds to a feature from QL4E not yet implemented for VSCode labels May 28, 2020
@aeisenberg
Copy link
Contributor

Do you have any more information on how this would work?

@jcreedcmu
Copy link
Contributor Author

This is related to how jump-to-definition already works, since https://github.com/github/codeql/blob/master/javascript/ql/src/localDefinitions.ql has an external predicate in it.

But the way the extension interacts with it is by already having baked in which external predicate it's going to supply data for --- I think if I remember right the idea of this issue was to let the user come across an arbitrary query with external predicates in it and provide some kind of interface for choosing data to put into them. https://help.semmle.com/QL/ql-handbook/annotations.html#external

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QL4E parity This issue corresponds to a feature from QL4E not yet implemented for VSCode VSCode
Projects
None yet
Development

No branches or pull requests

3 participants