Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake exit() unwind properly (minimal version) #5768
+154
−44
Conversation
CharlotteDunois
commented
Jun 25, 2020
|
Thank you, I'm all in for an internal exception with no userland behaviour change. |
|
When control returns to an internal function, will |
Yes, it will be set. Internal functions will work correctly if they handle exceptions correctly (e.g., don't throw warnings if an exception has been thrown). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nikic commentedJun 25, 2020
This is a minimal version of #5243. It switches exit() to throw an internal exception that is invisible to the user and only used to unwind the stack properly and perform a clean shutdown.
It does not execute finally block for exits, and leaves that issue for the future.