Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39797 Changes to socketserver.BaseServer's shutdown() method. #18929

Merged
merged 3 commits into from Mar 20, 2020
Merged

bpo-39797 Changes to socketserver.BaseServer's shutdown() method. #18929

merged 3 commits into from Mar 20, 2020

Conversation

amaajemyfren
Copy link
Contributor

@amaajemyfren amaajemyfren commented Mar 11, 2020

Copy link
Member

@ned-deily ned-deily left a comment

Thanks for the PR. Generally, for doc-only changes, there is no need to include a NEWS entry so please update the PR to remove it. Also as was noted elsewhere, in general you should just submit one PR and against the master branch (or whatever the highest applicable branch is). If accepted, the core developer will mark the PR to be automatically backported to appropriate maintenance branches. So I'm going to close the PRs you submitted against other branches so you don't need to update them.

@bedevere-bot
Copy link

bedevere-bot commented Mar 17, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

News is not needed for documentation PRs
@amaajemyfren
Copy link
Contributor Author

amaajemyfren commented Mar 19, 2020

Thanks for the PR. Generally, for doc-only changes, there is no need to include a NEWS entry so please update the PR to remove it.

Thanks. Will do so.

Also as was noted elsewhere, in general you should just submit one PR and against the master branch (or whatever the highest applicable branch is). If accepted, the core developer will mark the PR to be automatically backported to appropriate maintenance branches. So I'm going to close the PRs you submitted against other branches so you don't need to update them.

Thanks. I was not sure what to do and so I decided to write to the previous ones. Sorry for that.

@amaajemyfren
Copy link
Contributor Author

amaajemyfren commented Mar 19, 2020

Apologies for closing and reopening the PR. I clicked the wrong button when responding.

@amaajemyfren
Copy link
Contributor Author

amaajemyfren commented Mar 19, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Mar 19, 2020

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ned-deily Mar 19, 2020
@ned-deily ned-deily added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Mar 20, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 20, 2020

Thanks @amaajemyfren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Mar 20, 2020

GH-19085 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2020
…thonGH-18929)

Automerge-Triggered-By: @ned-deily
(cherry picked from commit 2de7ac9)

Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 20, 2020

GH-19086 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2020
…thonGH-18929)

Automerge-Triggered-By: @ned-deily
(cherry picked from commit 2de7ac9)

Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 20, 2020
…-18929)

Automerge-Triggered-By: @ned-deily
(cherry picked from commit 2de7ac9)

Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 20, 2020
…-18929)

Automerge-Triggered-By: @ned-deily
(cherry picked from commit 2de7ac9)

Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com>
@amaajemyfren amaajemyfren deleted the socketserver_documentation_master branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants