Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Clarify policy regarding 1 bpo issue per pull request #494
Comments
|
+1 I see "the oldest one" more like a guideline or preference than a hard rule. Sometimes there is another ticket with more or better information on the issue. It's a judgement call |
|
The other technique I've used is to keep the additional issue open, but have the associated PR be purely a docs change. That was for https://bugs.python.org/issue30661, where changing the default behaviour in the That would make the two possible resolutions be:
|
In python-dev mailing list, it was asked what to do when a PR will address multiple issues.
https://mail.python.org/archives/list/[email protected]/thread/74FS2DW2L4MDJXRREAABXYRWNI6INMBA/
From few answers from the core devs, seems like we prefer keeping only one issue open (the oldest one), and mark the rest as duplicates. Also, our workflow (bots and blurb) kinda expects 1 bpo issue per 1 pull request.
It would be great to clarify all of the above in either the pull request life cycle page, or in the triaging page.
The text was updated successfully, but these errors were encountered: