Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating << in mobile #372

Open
mariehuynh opened this issue May 16, 2018 · 10 comments
Open

Floating << in mobile #372

mariehuynh opened this issue May 16, 2018 · 10 comments
Labels

Comments

@mariehuynh
Copy link

@mariehuynh mariehuynh commented May 16, 2018

Shifts around when resizing and scrolling.

@brettcannon
Copy link
Member

@brettcannon brettcannon commented May 16, 2018

Can you share a screenshot?

@brettcannon
Copy link
Member

@brettcannon brettcannon commented May 16, 2018

Looks like a French-style quote.

@mariehuynh
Copy link
Author

@mariehuynh mariehuynh commented May 16, 2018

Probably just a 1-2 line CSS fix. I'll take a look when I get on a real machine.

@willingc
Copy link
Collaborator

@willingc willingc commented May 17, 2018

Hi @mariehuynh, This looks like the sidebar open/close is not rendering properly on Android. I don't see the same behavior on Safari or Chrome when sized to mobile width.

@willingc willingc added the bug label May 21, 2018
@mariehuynh
Copy link
Author

@mariehuynh mariehuynh commented May 30, 2018

I reproduced the problem on Chromium on Debian, and Chrome on a Mac, by reducing the size of the window and then scrolling horizontally.

@mariehuynh
Copy link
Author

@mariehuynh mariehuynh commented May 30, 2018

I don't see any CSS in this repo that affects this, and traced the problem back to the default CSS in Sphinx. We can override it via something like

div#sidebarbutton span {
position: sticky;
}

in tools/static/custom.css

@willingc
Copy link
Collaborator

@willingc willingc commented Jun 11, 2018

Thanks for the research @mariehuynh. I'm glad you were able to reproduce. Your suggestion seems like it will work. We may also see if the fix should be contributed back to the Sphinx project.

@mariehuynh
Copy link
Author

@mariehuynh mariehuynh commented Jun 11, 2018

I can make the change and run some tests. Can you point me at your protocol for testing before submission? What browsers are officially supported?

@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Sep 11, 2018

I think it's best to fix this upstream on Sphinx. Once the patch has been tested and accepted upstream we can either apply it here directly, or wait for the next Sphinx release.
We also don't have a specific list of supported browsers (other than "the main ones"), but Sphinx might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.