Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Floating << in mobile #372
Comments
|
Can you share a screenshot? |
|
Looks like a French-style quote. |
|
Probably just a 1-2 line CSS fix. I'll take a look when I get on a real machine. |
|
Hi @mariehuynh, This looks like the sidebar open/close is not rendering properly on Android. I don't see the same behavior on Safari or Chrome when sized to mobile width. |
|
I reproduced the problem on Chromium on Debian, and Chrome on a Mac, by reducing the size of the window and then scrolling horizontally. |
|
I don't see any CSS in this repo that affects this, and traced the problem back to the default CSS in Sphinx. We can override it via something like div#sidebarbutton span { in tools/static/custom.css |
|
Thanks for the research @mariehuynh. I'm glad you were able to reproduce. Your suggestion seems like it will work. We may also see if the fix should be contributed back to the Sphinx project. |
|
I can make the change and run some tests. Can you point me at your protocol for testing before submission? What browsers are officially supported? |
|
I think it's best to fix this upstream on Sphinx. Once the patch has been tested and accepted upstream we can either apply it here directly, or wait for the next Sphinx release. |
Shifts around when resizing and scrolling.
The text was updated successfully, but these errors were encountered: