bpo-39622: Use a custom signal handler in asyncio.run()

[kmaork]

In short - the default python SIGINT handler can cause the event loop to lose handles and get stuck. Therefore when running a loop we should use a SIGINT handler more fitting to the situation.
See detailed explanation (and bug demo scripts) here - https://bugs.python.org/issue39622

https://bugs.python.org/issue39622

[asvetlov]

We discussed this with @1st1 and declined because the approach cannot interrupt the infinite loop without yield-point, e.g.

while True:
    pass

[kmaork]

Thank you for your review. I've responded on the thread in https://bugs.python.org/issue39622

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[codecov]

Codecov Report

Merging #18628 into master will increase coverage by 1.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18628       +/-   ##
===========================================
+ Coverage   82.12%   83.22%    +1.09%     
===========================================
  Files        1956     1571      -385     
  Lines      589917   415337   -174580     
  Branches    44479    44489       +10     
===========================================
- Hits       484497   345666   -138831     
+ Misses      95770    60023    -35747     
+ Partials     9650     9648        -2     

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	30.00% <0.00%> (-65.00%)	⬇️
Lib/distutils/command/bdist_rpm.py	7.63% <0.00%> (-56.88%)	⬇️
Lib/test/test_urllib2net.py	76.92% <0.00%> (-13.85%)	⬇️
Lib/test/test_smtpnet.py	78.57% <0.00%> (-7.15%)	⬇️
Lib/ftplib.py	63.85% <0.00%> (-6.06%)	⬇️
Lib/test/test_ftplib.py	87.11% <0.00%> (-4.72%)	⬇️
Tools/scripts/db2pickle.py	17.82% <0.00%> (-3.97%)	⬇️
Tools/scripts/pickle2db.py	16.98% <0.00%> (-3.78%)	⬇️
Lib/test/test_socket.py	71.94% <0.00%> (-3.77%)	⬇️
Lib/test/test_asyncio/test_base_events.py	92.02% <0.00%> (-3.12%)	⬇️
... and 442 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f17c5c...616bf89. Read the comment docs.

[kmaork]

Hey, @asvetlov @1st1 , did you see my changes?

[1st1]

Actually I kind of like this approach. @asvetlov?

[kmaork]

Hello there @asvetlov, @1st1, it's been some time! I Shouldn't we at least change the tag to "awaiting review"?

[remilapeyre]

Hello there @asvetlov, @1st1, it's been some time! I Shouldn't we at least change the tag to "awaiting review"?

Hi @kmaork, as said in #18628 (comment) you can reply with "I have made the requested changes; please review again" and the tag will be updated.

[kmaork]

Damn, completely missed that. Thanks! I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@1st1: please review the changes made to this pull request.

[itay-sho]

Hey there! I have encountered exactly this issue. any chance that it'll be merged any time soon?

[asvetlov]

@kmaork could you please synchronize the PR with the main branch before I'll start the actual review process?

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[asvetlov]

Closed for the sake of #32105

[asvetlov]

Thanks for the inspiration!