bpo-39759: fixed os.getenv docs #18668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remilapeyre
reviewed
Feb 26, 2020
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please fix also the documentation for getenvb.
Contributor
|
@dorosch Would you still be interested in updating this PR per Serhiy's comment? |
Member
|
The proposed change removes a useful information: that the result is a string if the key is found (and it is a bytes object in Also, the docstrings say the same as the documentation, so it should be updated correspondingly. |
Contributor
|
Will start on a new PR here then, let me know if you'd still like to work on this one. |
Contributor
|
See #98113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39759