Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30656 Fixing documentation for PyModule_New() - now refers to proper function 'PyModule_NewObject()' #2170

Merged
merged 1 commit into from Jun 13, 2017
Merged

bpo-30656 Fixing documentation for PyModule_New() - now refers to proper function 'PyModule_NewObject()' #2170

merged 1 commit into from Jun 13, 2017

Conversation

emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Jun 13, 2017

This should be backported for all Python 3 versions.

willingc
willingc approved these changes Jun 13, 2017
View changes
Copy link
Contributor

@willingc willingc left a comment

Thanks @emilyemorehouse :D

@willingc willingc mentioned this pull request Jun 13, 2017
Closed
@Mariatta Mariatta added needs backport to 3.5 docs labels Jun 13, 2017
@Mariatta Mariatta merged commit 2d0afef into python:master Jun 13, 2017
2 checks passed
@Mariatta
Copy link
Sponsor Member

@Mariatta Mariatta commented Jun 13, 2017

Thanks @emilyemorehouse 🎉

Please backport to 3.5 and 3.6 using cherry_picker.py

The commit hash to be be used is 2d0afef82a07afdb666f2ca0c533aac5d39155cd.

mlouielu pushed a commit to mlouielu/cpython that referenced this issue Jun 15, 2017
@emilyemorehouse @mlouielu
bpo-30656: Fix Python C API Module Objects documentation (pythonGH-2170)
9daa77a 
`PyModule_New()` now refers to `PyModule_NewObject()`
Mariatta pushed a commit to Mariatta/cpython that referenced this issue Jun 16, 2017
@emilyemorehouse @Mariatta
[3.6] bpo-30656: Fix Python C API Module Objects documentation (pytho…
d989cdc 
…nGH-2170)

`PyModule_New()` now refers to `PyModule_NewObject()`
(cherry picked from commit 2d0afef)
Mariatta pushed a commit to Mariatta/cpython that referenced this issue Jun 16, 2017
@emilyemorehouse @Mariatta
[3.5] bpo-30656: Fix Python C API Module Objects documentation (pytho…
870d6dd 
…nGH-2170)

`PyModule_New()` now refers to `PyModule_NewObject()`
(cherry picked from commit 2d0afef)
Mariatta added a commit that referenced this issue Jun 16, 2017
@Mariatta
bpo-30656: Fix Python C API Module Objects documentation (GH-2170) (G…
6a90a12 
…H-2230)

`PyModule_New()` now refers to `PyModule_NewObject()`
(cherry picked from commit 2d0afef)
Mariatta added a commit that referenced this issue Jun 16, 2017
@Mariatta
bpo-30656: Fix Python C API Module Objects documentation (GH-2170) (G…
0b13f58 
…H-2231)

`PyModule_New()` now refers to `PyModule_NewObject()`
(cherry picked from commit 2d0afef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc

@Mariatta Mariatta

Assignees
No one assigned
Labels
CLA signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilyemorehouse @Mariatta @willingc @the-knights-who-say-ni