Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30644: Mention how to disable signal fd wakeup #2140

Merged
merged 1 commit into from Jun 13, 2017

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jun 12, 2017

No description provided.

@mention-bot
Copy link

mention-bot commented Jun 12, 2017

@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @loewis and @taleinat to be potential reviewers.

@pitrou
Copy link
Member Author

pitrou commented Jun 12, 2017

@njsmith

@njsmith
Copy link
Contributor

njsmith commented Jun 12, 2017

Yeah, good idea and lgtm

If you want to get really fancy, I guess you could also mention that on unixes it's an arbitrary FD, but on Windows it should be a socket handle (not an FD at all).

@pitrou
Copy link
Member Author

pitrou commented Jun 13, 2017

If I'm reading signalmodule.c correctly (especially the functions signal_set_wakeup_fd and trip_signal), we support both regular file descriptors and sockets on Windows (but not native Windows handles).

@pitrou pitrou merged commit d79c1d4 into python:master Jun 13, 2017
@pitrou pitrou deleted the wakeup_fd_doc_nit branch Jun 13, 2017
pitrou added a commit to pitrou/cpython that referenced this pull request Jun 13, 2017
pitrou added a commit to pitrou/cpython that referenced this pull request Jun 13, 2017
pitrou added a commit to pitrou/cpython that referenced this pull request Jun 13, 2017
@vstinner vstinner changed the title Mention how to disable signal fd wakeup bpo-30644: Mention how to disable signal fd wakeup Jun 13, 2017
pitrou added a commit that referenced this pull request Jun 13, 2017
pitrou added a commit that referenced this pull request Jun 13, 2017
pitrou added a commit that referenced this pull request Jun 13, 2017
@njsmith
Copy link
Contributor

njsmith commented Jun 13, 2017

we support both regular file descriptors and sockets on Windows (but not native Windows handles).

Ah, looks like you're right. In practice though I don't think there are any uses for passing in a regular file descriptor, because only sockets can be set in non-blocking mode, and python sockets are always represented as socket handles and not wrapped into an fd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants