Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39495: Remove default value from C impl of TreeBuilder.start #18275
Conversation
This comment has been minimized.
This comment has been minimized.
|
As suggested by Serhiy, this changes the C implementation of Note however, that the C implementation of TreeBuilder.start still accepts I looked into changing the C implementation to also throw a cpython/Modules/_elementtree.c Line 3315 in 188bb5b
|
Misc/NEWS.d/next/Library/2020-01-30-07-02-02.bpo-39495.8LsIRN.rst
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
Thank you for your PR @hauntsaninja. I prefer to remove also the support of None as a value of
|
This comment has been minimized.
This comment has been minimized.
|
Or you can just use |
Co-Authored-By: Dong-hee Na <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
Thanks Dong-hee and Serhiy! Don't know much about argument clinic converters, that's a neat fix. |
|
Looks good. |
hauntsaninja commentedJan 30, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39495