[2.7] bpo-33006 - Correct filter doc string to clarify 2nd argument can be iterable#6015
[2.7] bpo-33006 - Correct filter doc string to clarify 2nd argument can be iterable#6015miss-islington merged 6 commits intopython:2.7from TonyFlury:bpo-33006
Conversation
Python/bltinmodule.c
Outdated
| iteration, or an iterator. If iterable is a string or a tuple, the result\n\ | ||
| also has that type; otherwise it is always a list. If function is None, the\n\ | ||
| identity function is assumed, that is, all elements of iterable that are\n\ | ||
| false are removed."); |
There was a problem hiding this comment.
While accurate, it seems a bit too verbose for a doc string. How about using the current Python 3 docstring as a starting point?
| Return an iterator yielding those items of iterable for which function(item)
| is true. If function is None, return the items that are true.
s/an iterator/a sequence/ and include the 'If iterable is a string or tuple ...' sentence?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the changes @TonyFlury. And thanks for the reminder @csabella!
ned-deily
changed the title
|
@TonyFlury: Status check is done, and it's a success ✅ . |
5 participants
https://bugs.python.org/issue33006