Skip to content

/ msgpack-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make strict_map_key default to True #392

Merged
merged 1 commit into from Dec 6, 2019
Merged

Make strict_map_key default to True #392

merged 1 commit into from Dec 6, 2019

Conversation

@methane
Copy link
Member

@methane methane commented Dec 6, 2019

No description provided.

@methane
Make strict_map_key default to True
Loading status checks…
6e1d12c
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 6, 2019 •
edited

Codecov Report

Merging #392 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files           5        5           
  Lines         808      808           
=======================================
  Hits          711      711           
  Misses         97       97
Impacted Files Coverage Δ
msgpack/fallback.py 89.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc0eb2...6e1d12c. Read the comment docs.
@methane methane merged commit d8e3cf0 into msgpack:master Dec 6, 2019
4 checks passed
4 checks passed
black
Details
build
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@methane methane deleted the methane:strict-key branch Dec 6, 2019
@KevinHake
KevinHake reviewed Apr 15, 2020
View changes
Copy link

@KevinHake KevinHake left a comment •
edited

What's the motivation for changing the default?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinHake KevinHake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@methane @codecov-io @KevinHake
You can’t perform that action at this time.