Skip to content

/ msgpack-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback Unpacker.read_bytes() #388

Merged
merged 2 commits into from Dec 6, 2019
Merged

Fix fallback Unpacker.read_bytes() #388

merged 2 commits into from Dec 6, 2019

Conversation

@methane
Copy link
Member

@methane methane commented Dec 6, 2019

Fixes #352.
methane added 2 commits Dec 6, 2019
@methane
Fix fallback Unpacker.read()
Loading status checks…
be520a4 
Fixes #352.
@methane
black
Loading status checks…
15e017a
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 6, 2019 •
edited

Codecov Report

Merging #388 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   87.96%   87.99%   +0.02%     
==========================================
  Files           5        5              
  Lines         806      808       +2     
==========================================
+ Hits          709      711       +2     
  Misses         97       97
Impacted Files Coverage Δ
msgpack/fallback.py 89.03% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8ce0f...15e017a. Read the comment docs.
@methane methane merged commit f6f6f32 into msgpack:master Dec 6, 2019
3 checks passed
3 checks passed
build
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@methane methane deleted the methane:issue-352 branch Dec 6, 2019
@methane methane changed the title Fix fallback Unpacker.read() Fix fallback Unpacker.read_bytes() Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Broken fallback implementation of Unpacker.read_bytes
2 participants
@methane @codecov-io
You can’t perform that action at this time.