Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Autotools.gitignore #3005

Merged
merged 2 commits into from Aug 7, 2019
Merged

Update Autotools.gitignore #3005

merged 2 commits into from Aug 7, 2019

Conversation

@stevenleeS0ht
Copy link
Contributor

@stevenleeS0ht stevenleeS0ht commented Mar 19, 2019

Add ignore-rule for Makefiles generated by configure
(directly by config.status)

Reasons for making this change:
Makefiles are also unnecessary to be tracked because they are also be generated.

Links to documentation supporting these rule changes:

TODO

Add ignore-rule for Makefiles generated by configure
(directly by config.status)
@shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 20, 2019

@stevenleeS0ht any links to StackOverflow discussions or other documentation about this change?

@shiftkey shiftkey added the needs info label Mar 21, 2019
@alepinio
Copy link

@alepinio alepinio commented Jul 30, 2019

you can read in

https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#Making-configure-Scripts

that configure creates the Makefiles

and so as configure is actually included Autotools.gitignore, the Makefiles should be also included

@stevenleeS0ht
Copy link
Contributor Author

@stevenleeS0ht stevenleeS0ht commented Jul 31, 2019

@shiftkey , It would be well-known that Makefile (or Ninja) is generated without any handwritten part by Meta-build system. (Autotools, CMake, SCons and etc.). That is why we use those tools. :)

Autotools.gitignore Outdated Show resolved Hide resolved
Add more descriptive comment to explain why Makefile should be ignore.
@shiftkey
Copy link
Member

@shiftkey shiftkey commented Aug 7, 2019

@stevenleeS0ht thanks!

@shiftkey shiftkey merged commit e92f8db into github:master Aug 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
SaifurRahmanMohsin added a commit to SaifurRahmanMohsin/gitignore that referenced this pull request Aug 29, 2019
* upstream/master:
  Added Simulink cache files (github#3148)
  Add esp-idf.gitignore (github#3150)
  Add *.sch-bak to KiCad.gitignore (github#3153)
  Reference why to exclude binary jar, fixes github#111 (github#3154)
  Update Autotools.gitignore (github#3005)
  Improving the documentation of Objective-C and Swift files (github#3133)
  Ignore gummi previews (github#3144)
  Swift: ignore .swiftpm (github#3083)
  Update Godot.gitignore (github#3142)
  Revert of github#2988. TextMesh Pro files are not auto managed (github#3134)
  Partial revert of 837181e (github#3132)
  Added more glossaries auxiliary files and makeindex logs to TeX template (github#3104)
  .travis.yml: Trim trailing whitespace and indent (github#3118)
  Add *.hie to Haskell.gitignore (github#3120)
  Ignore the .ionide working folder (github#3108)
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
* Update Autotools.gitignore

Add ignore-rule for Makefiles generated by configure
(directly by config.status)

* Add some descriptive comment.

Add more descriptive comment to explain why Makefile should be ignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants