Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33187: Fix document ElementInclude (XInclude) support in ElementTree issue #8861

Merged
merged 10 commits into from Sep 11, 2019

Conversation

@bansalanjali2512
Copy link
Contributor

commented Aug 22, 2018 •
edited by bedevere-bot

https://bugs.python.org/issue33187
@bansalanjali2512
fix-issue-33187
5fd67ed
@bansalanjali2512
bpo-33187: Fix document ElementInclude (XInclude) support in ElementT… 
…ree issue
Loading status checks…
3fd25b0

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 22, 2018

@bedevere-bot bedevere-bot added type-documentation awaiting review labels Aug 22, 2018

@berkerpeksag berkerpeksag added the skip news label Aug 22, 2018

@eamanu
eamanu approved these changes Aug 23, 2018
View changes

@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Aug 23, 2018

@scoder
scoder requested changes Aug 23, 2018
View changes
Copy link
Contributor

left a comment

Thanks! I left some comments.
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
Doc/library/xml.etree.elementtree.rst Outdated Show resolved Hide resolved
@scoder

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 23, 2018

Please also fix the travis errors. There seems to be trailing whitespace in the file.

@serhiy-storchaka serhiy-storchaka added the awaiting changes label Oct 15, 2018

@scoder

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 14, 2019

Any update on this? It would be nice to get this ready to be merged.
@bansalanjali2512
Some suggested changes on the pull request added.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c59bb27
@tirkarthi

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented May 7, 2019

There are some trailing spaces in the PR. Please try running make patchcheck locally that will fix the whitespace related errors.

@JulienPalard JulienPalard removed the awaiting core review label Sep 10, 2019

scoder added 7 commits Sep 11, 2019
@scoder
Minor text changes from review.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e5c8bcb
@scoder
Minor changes from review.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f0305c7
@scoder
Improve formatting.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0e00982
@scoder
Fix formatting issues.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
81ddf6a
@scoder
Fix formatting issue.
56372f9
@scoder
Silence sphinx checking warnings.
Loading status checks…
397bf0c
@scoder
Silence sphinx checking warnings.
Loading status checks…
acd67ed
@scoder
scoder approved these changes Sep 11, 2019
View changes

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Sep 11, 2019

@scoder scoder merged commit 97b817e into python:master Sep 11, 2019
4 checks passed

4 checks passed

Azure Pipelines PR #20190911.121 succeeded
Details
bedevere/issue-number Issue number 33187 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bedevere-bot bedevere-bot removed the awaiting merge label Sep 11, 2019

@scoder scoder added the needs backport to 3.8 label Sep 11, 2019

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

Thanks @bansalanjali2512 for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@bansalanjali2512 @miss-islington
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (p… 
…ythonGH-8861)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
b6ebdda
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

GH-15958 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 11, 2019

scoder added a commit that referenced this pull request Sep 11, 2019
@miss-islington @bansalanjali2512 @scoder
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (G… 
…H-8861) (GH-15958)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
6cf0ba8

@scoder scoder added the needs backport to 3.7 label Sep 11, 2019

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

Thanks @bansalanjali2512 for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@bansalanjali2512 @miss-islington
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (p… 
…ythonGH-8861)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
18df2c8
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

GH-15972 is a backport of this pull request to the 3.7 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Sep 11, 2019

scoder added a commit that referenced this pull request Sep 11, 2019
@miss-islington @bansalanjali2512 @scoder
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (G… 
…H-8861) (GH-15972)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
Loading status checks…
195dc14
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
@bansalanjali2512 @vrpolakatcisco
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (p… 
…ythonGH-8861)
75064c1
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@bansalanjali2512 @DinoV
bpo-33187: Document ElementInclude (XInclude) support in ElementTree (p… 
…ythonGH-8861)
33d5180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoder scoder

@eamanu eamanu

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
10 participants
@bansalanjali2512 @scoder @tirkarthi @miss-islington @bedevere-bot @eamanu @berkerpeksag @JulienPalard @serhiy-storchaka @the-knights-who-say-ni
You can’t perform that action at this time.