Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36634: Fixes activate.bat when existing values contain double quotes #15924

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@zooba
Copy link
Member

commented Sep 11, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue36634
@zooba
bpo-36634: Fixes activate.bat when existing values contain double quotes
Loading status checks…
e9221e9

@zooba zooba added type-bugfix OS-windows needs backport to 3.7 needs backport to 3.8 labels Sep 11, 2019

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 11, 2019

@bedevere-bot bedevere-bot added the awaiting core review label Sep 11, 2019

@zooba
Remove risk of parentheses breaking script
Loading status checks…
45d364a
@zware
zware approved these changes Sep 11, 2019
View changes
Copy link
Member

left a comment

LGTM

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 11, 2019

@zware zware merged commit 574b324 into python:master Sep 11, 2019
5 checks passed

5 checks passed

Azure Pipelines PR #20190911.100 succeeded
Details
bedevere/issue-number Issue number 36634 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Sep 11, 2019

@zooba zooba deleted the zooba:bpo-36634 branch Sep 11, 2019

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@zooba @miss-islington
bpo-36634: Fixes activate.bat when existing values contain double quo… 
…tes (pythonGH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
ed1386f
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

GH-15968 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 11, 2019

@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 11, 2019

GH-15969 is a backport of this pull request to the 3.7 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Sep 11, 2019

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@zooba @miss-islington
bpo-36634: Fixes activate.bat when existing values contain double quo… 
…tes (pythonGH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
71e1f54
miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @zooba
bpo-36634: Fixes activate.bat when existing values contain double quo… 
…tes (GH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
20f80bf
miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @zooba
bpo-36634: Fixes activate.bat when existing values contain double quo… 
…tes (GH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a19a91
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
@zooba @vrpolakatcisco
bpo-36634: Fixes activate.bat when existing values contain double quo… 
…tes (pythonGH-15924)
125623f
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@zooba @DinoV
bpo-36634: Fixes activate.bat when existing values contain double quo… 
…tes (pythonGH-15924)
b4c9ea6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware

Assignees
No one assigned
Labels
CLA signed OS-windows type-bugfix
Projects
None yet
Milestone
No milestone
5 participants
@zooba @miss-islington @bedevere-bot @zware @the-knights-who-say-ni
You can’t perform that action at this time.