Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38547: Fix test_pty if the process is the session leader #17519
Conversation
Fix test_pty: if the process is the session leader, closing the master file descriptor raises a SIGHUP signal: simply ignore SIGHUP when running the tests.
vstinner
added
needs backport to 3.7
needs backport to 3.8
and removed
CLA signed
awaiting core review
type-tests
labels
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 9, 2019
|
Thanks @vstinner for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2019
…H-17519) Fix test_pty: if the process is the session leader, closing the master file descriptor raises a SIGHUP signal: simply ignore SIGHUP when running the tests. (cherry picked from commit a1838ec) Co-authored-by: Victor Stinner <[email protected]>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 9, 2019
|
GH-17520 is a backport of this pull request to the 3.8 branch. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 9, 2019
|
GH-17521 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2019
…H-17519) Fix test_pty: if the process is the session leader, closing the master file descriptor raises a SIGHUP signal: simply ignore SIGHUP when running the tests. (cherry picked from commit a1838ec) Co-authored-by: Victor Stinner <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Dec 9, 2019
Fix test_pty: if the process is the session leader, closing the master file descriptor raises a SIGHUP signal: simply ignore SIGHUP when running the tests. (cherry picked from commit a1838ec) Co-authored-by: Victor Stinner <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Dec 9, 2019
Fix test_pty: if the process is the session leader, closing the master file descriptor raises a SIGHUP signal: simply ignore SIGHUP when running the tests. (cherry picked from commit a1838ec) Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedDec 9, 2019
•
edited by bedevere-bot
Fix test_pty: if the process is the session leader, closing the
master file descriptor raises a SIGHUP signal: simply ignore SIGHUP
when running the tests.
https://bugs.python.org/issue38547