Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse modern clone dialog when re-cloning a repository #2202
Conversation
jcansdale
added some commits
Jan 28, 2019
jcansdale
changed the base branch from
master
to
fixes/2196-clone-progress
Jan 28, 2019
jcansdale
changed the base branch from
fixes/2196-clone-progress
to
master
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
|
@prasethu I'm trying to test this PR, but the cloned URLs don't appear on the I was always unsure about when they were supposed to appear. I'd like to understand what's going on now so we can test it properly. Update: I see the URL link appears when you delete the repository folder. It all makes sense now! |
jcansdale
requested review from
prasethu,
grokys and
meaghanlewis
Jan 28, 2019
jcansdale
added
Ready for Review
enhancement
labels
Jan 28, 2019
jcansdale
merged commit a49e5de
into
master
Jan 29, 2019
jcansdale
deleted the
fixes/2199-reclone-using-new-open-clone-dialog
branch
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jcansdale commentedJan 28, 2019
•
edited
Depends on #2198
Now that the clone dialog can clone any arbitrary GitHub URL (not just ones owned by the user), we don't need a separate dialog when re-cloning a URL using the
Start Page.What this PR does
ShowReCloneDialogAPI and related classesHow to test
Start Page(clickFile > Start Page)GitHubbutton which is underOpenStart Page(clickFile > Start Page)https://link to the repository you cloned then deletedOpen from GitHubdialog should appearFixes #2199