Skip to content

/ libgit2sharp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stated platform support #1679

Closed
wants to merge 2 commits into from
Closed

update stated platform support #1679

wants to merge 2 commits into from

Conversation

@adamralph
Copy link

@adamralph adamralph commented May 16, 2019

I'm not sure if this is the best way of stating it, but it does bring the statements up to date.
@adamralph
update stated platform support
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7825eed
@bording
bording reviewed May 16, 2019
View changes
README.md Outdated Show resolved Hide resolved
@bording
Copy link
Member

@bording bording commented May 16, 2019

@adamralph This gets a bit tricky due to the native binary requirement. For example even though it has a netstandard2.0 assembly, actual platform support depends on what native binaries are available.
@adamralph
correct prequisite from .NET 4.6.1+ to .NET 4.6+
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e864c0
@adamralph
Copy link
Author

@adamralph adamralph commented May 17, 2019

@bording

It actually supports .NET Framework 4.6, so that should also be changed.

👍 I've made that change.

This gets a bit tricky due to the native binary requirement. For example even though it has a netstandard2.0 assembly, actual platform support depends on what native binaries are available.

True, but I'm afraid I have little knowledge about that all that. I think this PR is a step in the right direction, but please feel free to do what you want with it, including closing it if you'd rather handle this later and all at once.
@adamralph adamralph closed this Sep 21, 2020
@adamralph adamralph deleted the adamralph:patch-1 branch Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bording bording

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@adamralph @bording
You can’t perform that action at this time.