Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that clone from Start Page shows progress status bar #2198

Merged
merged 4 commits into from Jan 28, 2019

Conversation

@jcansdale
Copy link
Collaborator

jcansdale commented Jan 25, 2019

You can find a VSIX installer for this PR here:
https://ci.appveyor.com/api/buildjobs/cm5ipkqbus5g6ca0/artifacts/2.8.0.6611%2FGitHub.VisualStudio.vsix

What this PR does

Ensure that cancellationToken and progress arguments are propagated to the CloneAsync. This will make clone progress appear on the status bar when initiated via the Start Page (or Get to Code).

How to test

  1. Click the GitHub button on the Start Page

image

  1. Select a repository and click Clone

image

  1. Check progress appears on the status bar

image

Fixes #2196

jcansdale added 2 commits Jan 25, 2019
@jcansdale jcansdale requested a review from meaghanlewis Jan 25, 2019
Copy link
Collaborator

prasethu left a comment

Thanks. Tested and saw that it works great!

@prasethu
Copy link
Collaborator

prasethu commented Jan 26, 2019

Folks, any ETA on getting this merge? Thank you.

@jcansdale
Copy link
Collaborator Author

jcansdale commented Jan 28, 2019

@prasethu is there a particular date we should aim for?

@grokys
grokys approved these changes Jan 28, 2019
@jcansdale jcansdale merged commit fced2fe into master Jan 28, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190128.13 succeeded
Details
@jcansdale jcansdale deleted the fixes/2196-clone-progress branch Jan 28, 2019
@prasethu
Copy link
Collaborator

prasethu commented Jan 28, 2019

@jcansdale You've already merged it 👍

I can't speak exactly to release dates, but pretty soon - a month or so.

Would this be available as a release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.