NullReferenceException trying to clear tracker parameter (iOS) #161

nicolasjinchereau · 2017-10-04T04:39:24Z

To clear a parameter, you should pass nil to value:

google-analytics-plugin-for-unity/source/Plugins/iOS-nobitcode/GAITracker.h

Lines 33 to 37 in 49a1ddf

    
            @param value The value to set for the parameter. If this is nil, the 
        
            value for the parameter will be cleared. 
        
            */ 
        
           - (void)set:(NSString *)parameterName 
        
                 value:(NSString *)value;

But first, this call is made, which calls +(NSString)stringWithUTF8String on value, which will throw when null is passed.

google-analytics-plugin-for-unity/source/Plugins/iOS-bitcode/GAIHandler.m

Lines 108 to 113 in 49a1ddf

    
           void set(const char * parameterName, const char * value ) { 
        
               id<GAITracker> tracker = [[GAI sharedInstance] defaultTracker]; 
        
               [tracker set:[NSString stringWithUTF8String:parameterName] 
        
                      value:[NSString stringWithUTF8String:value ]]; 
        
           }

But before calling those two, you must call this in C#, which calls ToString() on the value without checking if it's null.

google-analytics-plugin-for-unity/source/Plugins/GoogleAnalyticsV3/GAIHandler.cs

Lines 95 to 97 in 5a5caee

    
           public void _set(string parameterName, object value){ 
        
             set(parameterName, value.ToString()); 
        
           }

Finally, SetTrackerVal, which should be able to accept null to clear parameters, but crashes due to aforementioned problems.

google-analytics-plugin-for-unity/source/Plugins/GoogleAnalyticsV3/GoogleAnalyticsiOSV3.cs

Lines 124 to 126 in 5a5caee

    
           public void SetTrackerVal(Field fieldName, object value){ 
        
             handler._set(fieldName.ToString(), value); 
        
           }

googleanalytics / google-analytics-plugin-for-unity

NullReferenceException trying to clear tracker parameter (iOS) #161

NullReferenceException trying to clear tracker parameter (iOS) #161

nicolasjinchereau commented Oct 4, 2017

googleanalytics / google-analytics-plugin-for-unity

Join GitHub today

NullReferenceException trying to clear tracker parameter (iOS) #161

NullReferenceException trying to clear tracker parameter (iOS) #161

Comments

nicolasjinchereau commented Oct 4, 2017

Essential cookies

Always active

Analytics cookies