This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Merged
Conversation
robrix
approved these changes
Jul 14, 2019
Co-Authored-By: Rob Rix <robrix@github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the process of generating haskell code from proto files a bit more repeatable by doing all the work in a docker container instead of relying on people's local setup of the protocol buffer complier and associated plugins. There are a couple of rough edges here due to https://github.com/tclem/twirp-haskell not being quite powerful enough, but it gets the job done. I'm also moving the service proto definitions out of the repo as semantic doesn't expose a service.