Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-23205: IDLE: Add tests and refactor grep's findfiles #12203

Merged
merged 7 commits into from Mar 23, 2019
Merged

bpo-23205: IDLE: Add tests and refactor grep's findfiles #12203

merged 7 commits into from Mar 23, 2019

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Mar 6, 2019 •
edited by bedevere-bot

  • Add tests for grep's findfiles.
  • Move findfiles from inside the GrepDialog class to be a module function.
  • Refactor findfiles to use os.walk.

Based on a patch by Al Sweigart.

https://bugs.python.org/issue23205

@csabella csabella requested a review from terryjreedy as a code owner Mar 6, 2019
terryjreedy
terryjreedy approved these changes Mar 23, 2019
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Looks good.

ZackerySpytz
ZackerySpytz reviewed Mar 23, 2019
View changes
Lib/idlelib/grep.py Outdated Show resolved Hide resolved
@csabella csabella merged commit d60f658 into python:master Mar 23, 2019
5 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 23, 2019

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@csabella csabella deleted the bpo23205 branch Mar 23, 2019
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 23, 2019

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 23, 2019

GH-12512 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 23, 2019
@csabella @miss-islington
bpo-23205: IDLE: Add tests and refactor grep's findfiles (pythonGH-12203
eddf447 
)

* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
(cherry picked from commit d60f658)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this issue Mar 23, 2019
@miss-islington @csabella
bpo-23205: IDLE: Add tests and refactor grep's findfiles (GH-12203)
5ab6650 
* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
(cherry picked from commit d60f658)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
ma8ma pushed a commit to ma8ma/cpython that referenced this issue Apr 7, 2019
@csabella @ma8ma
bpo-23205: IDLE: Add tests and refactor grep's findfiles (pythonGH-12203
9d1d473 
)

* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
arnolddumas pushed a commit to arnolddumas/cpython that referenced this issue May 3, 2019
@csabella @arnolddumas
bpo-23205: IDLE: Add tests and refactor grep's findfiles (pythonGH-12203
46dbdf2 
)

* Add tests for grep findfiles.
* Move findfiles to module function.
* Change findfiles to use os.walk.

Based on a patch by Al Sweigart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz

@terryjreedy terryjreedy

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @ZackerySpytz @the-knights-who-say-ni