Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 263: fix typo in coding regex #672

Merged
merged 1 commit into from Jun 15, 2018
Merged

Conversation

@enterprisey
Copy link
Contributor

@enterprisey enterprisey commented Jun 14, 2018

The characters before the # in a coding declaration line can be spaces, tabs, or form feeds; the escape sequence for a form feed is a \f, not a \v as is shown here.

The characters before the # in a coding declaration line can be spaces, tabs, or form feeds; the escape sequence for a form feed is a `\f`, not a `\v` as is shown here.
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Jun 14, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@enterprisey
Copy link
Contributor Author

@enterprisey enterprisey commented Jun 15, 2018

I've signed the CLA and my bugs.python.org account has updated to reflect this

@brettcannon brettcannon merged commit 65edc87 into python:master Jun 15, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Jun 15, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants