@ethomson I think something might be wrong with the AppVeyor setup. If you take a look at the details, it actually says one test failed, but it's still reporting everything as green...

I think something might be wrong with the AppVeyor setup. If you take a look at the details, it actually says one test failed, but it's still reporting everything as green...

Haha, that's delightful:

- ps: |
    Foreach ($runner in 'xunit.console.exe','xunit.console.x86.exe')
    {
      If ($Env:SHOULD_RUN_COVERALLS -eq $True -and $Env:publish_on_success -eq $True)
      {
        .\packages\OpenCover\tools\OpenCover.Console.exe `
          -register:user `
          "-target:""$Env:userprofile\.nuget\packages\xunit.runner.console\2.3.1\tools\net452\$runner""" `
          "-targetargs:""$Env:APPVEYOR_BUILD_FOLDER\bin\LibGit2Sharp.Tests\Release\net461\LibGit2Sharp.Tests.dll"" -noshadow" `
          "-filter:+[LibGit2Sharp]* -[LibGit2Sharp.Tests]*" `
          -hideskipped:All `
          -output:opencoverCoverage.xml
      }
      ElseIf ($Env:SHOULD_RUN_COVERITY_ANALYSIS -eq $False)
      {
        & "$Env:userprofile\.nuget\packages\xunit.runner.console\2.3.1\tools\net452\$runner" `
            "$Env:APPVEYOR_BUILD_FOLDER\bin\LibGit2Sharp.Tests\Release\net461\LibGit2Sharp.Tests.dll" -noshadow
      }
    }

Maybe the return code is not being bubbled up? I'll poke around with this when I have some time.

Re-ran the AppVeyor tests on this one, and they all passed this time.