Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add C# stacktrace info to CRTDBG leak reporting. #1125
Closed
Conversation
|
@jeffhostetler Could you please tweak the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This change extends the CRTDBG memory leak stack trace to include C# stack frames (the context of the PInvoke). This code depends upon: libgit2/libgit2#3202
@nulltoken I've guarded this code with LEAKS_CRTDBG similar to your other LEAKS_ definitions. I was able to run this within VS in debug mode, but had issues with the build.libgit2sharp.cmd unpacking the nuget package and overwriting my locally built version of libgit2.dll, so I'm wondering if there's something I need to do different to run the suite from the command line, but that's another conversation. Anyway, could you give this a spin and see if the results make sense to you? Thanks!