➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2018-02-17 03:24 by izbyshev, last changed 2021-03-20 14:32 by vstinner.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 5713 | open | izbyshev, 2018-02-17 03:28 | |
| Messages (3) | |||
|---|---|---|---|
| msg312266 - (view) | Author: Alexey Izbyshev (izbyshev) *  |
Date: 2018-02-17 03:24 | |
os.dup2(fd, fd, inheritable=False) may fail or change fd inheritability in following ways: 1) POSIX without F_DUP2FD_CLOEXEC 1.1) dup3() is available (a common case for Linux): OSError (EINVAL, dup3() doesn't allow equal descriptors) 1.2) dup3() is not available: fd made non-inheritable 2) POSIX with F_DUP2FD_CLOEXEC (FreeBSD): inheritability is not changed 3) Windows: fd made non-inheritable In contrast, os.dup2(fd, fd, inheritable=True) never changes fd inheritability (same as before PEP 446 landed). I suggest to make os.dup2(fd, fd, inheritable=False) behave the same. |
|||
| msg312295 - (view) | Author: Eryk Sun (eryksun) * |
Date: 2018-02-18 02:26 | |
In Windows the CRT file descriptor is actually still inheritable. This only makes the underlying OS handle non-inheritable. I don't think there's a way to make an existing FD non-inheritable using public CRT functions. See issue 32865. |
|||
| msg312298 - (view) | Author: Alexey Izbyshev (izbyshev) * |
Date: 2018-02-18 04:36 | |
@eryksun: Thank you for the note! I've commented on #32865. This adds even more inconsistency to this corner case. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2021-03-20 14:32:55 | vstinner | set | nosy:
- vstinner |
| 2021-03-20 06:38:25 | eryksun | set | versions: + Python 3.8, Python 3.9, Python 3.10, - Python 3.6, Python 3.7 |
| 2018-02-18 04:36:34 | izbyshev | set | messages: + msg312298 |
| 2018-02-18 02:26:17 | eryksun | set | nosy:
+ eryksun messages: + msg312295 |
| 2018-02-17 03:28:12 | izbyshev | set | keywords:
+ patch stage: patch review pull_requests: + pull_request5503 |
| 2018-02-17 03:24:02 | izbyshev | create | |